Drop spree_gateways table#323
Merged
jordan-brough merged 1 commit intoAug 25, 2015
Merged
Conversation
Spree::Gateway inherits from Spree::PaymentMethod and uses the spree_payment_methods table.
jordan-brough
force-pushed
the
remove-spree-gateways-table
branch
from
2ebd65d to
f0e3c58
Compare
Contributor
|
Guess someone made a booboo while they were building |
Contributor
|
👍 |
Contributor
|
👍 I'm sure it was made by accident. We removed |
Contributor
Author
|
Cool. Fwiw, I think I found the history: 062c2d3#diff-2e15d5409a141ad2f6ab3a8f7b1dd51d (an unfinished TODO item) |
jordan-brough
added a commit
that referenced
this pull request
Aug 25, 2015
Drop spree_gateways table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spree::Gateway inherits from Spree::PaymentMethod and uses the
spree_payment_methods table.
Does anyone know the history of why this table exists? I took a quick look and it wasn't immediately obvious. It's empty in our DB.
(I'm a bit nervous about dropping something like this w/o knowing the story for it)