Admin styles clean#36
Merged
Merged
Conversation
This was only used in the border-radius mixin, which does nothing.
There is a reason that typographical elements come with margin and padding, so that you don't have to pad out each one you use individually. This sweeping change affects suprisingly little because the admin area is mostly table-based. However, I suspect that there will now be redundant additions of padding and or margin in other areas.
Contributor
|
nice |
Contributor
|
👍 |
By using Bootstrap's "media" element, we can trade styles which are in no way reusable, for ones which are super generic.
I would rather drop $font-weight-bold entirely and use `bold` throughout the admin. But if the $font-weight-bold *must* be 600 (really?) then let's at least use the var that was presumably here to hold that odd value.
This is what it was presumably added for.
We're already using a normalize which provides reasonable outline styles (thin dotted line), there's no reason to just nuke these out of hand and eliminate all hope of keyboard navigation of the admin area.
|
👍 |
Contributor
|
👍 from me. Happy to trade some slightly awkward active states for better css. The select2 dropdown looks way better. |
|
👍 |
waiting-for-dev
added a commit
that referenced
this pull request
Nov 3, 2022
We're grouping changes by the solidus component they belong to. E.g. (PR numbers and full changelog range would be linkable): --- What's Changed Solidus Core - Fix bug by @waiting-for-dev in #36 - Add cool feature by @waiting-for-dev in #37 Solidus Admin - Make something compatible by @waiting-for-dev in #35 Solidus API - Add endpoint by @waiting-for-dev in #34 Full Changelog: v3.2.0...v3.3.0 --- That configuration makes the release notes follow the same schema that we're using in the Changelog file [1]. Unfortunately, it's not possible to change the release or PR templates to make them identical. [1] - https://github.com/solidusio/solidus/blob/master/CHANGELOG.md
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 26, 2024
Fix Promotion Map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these changes are just trading specific styles for generic reusable ones.
Varient Select2 Dropdown
before
after
New Outlines
There will be some active states where there were not before.
main nav
form fields
icon buttons
This one is not the greatest out-of-the-box, but I'll address it in a more general cleanup of icon-buttons.