Fix #326: Rename routes due to deprecation of open/close on order adjustments#434
Merged
cbrunsdon merged 1 commit intoDec 11, 2015
Conversation
…order adjustments * Rename routes to `/admin/orders/:id/adjustments/finalize` and `/admin/orders/:id/adjustments/unfinalize` * Replace open/close with unfinalize/finalize.
There was a problem hiding this comment.
is it worth moving it to a separate controller/resource at this point?
Contributor
|
I'm 👍 on this. I'd be happy to consider moving this to a separate controller but would probably do that in a separate PR. @cbrunsdon? |
Contributor
|
good by me for now! thanks. @bsodmike 👍 |
cbrunsdon
added a commit
that referenced
this pull request
Dec 11, 2015
…routes Fix #326: Rename routes due to deprecation of open/close on order adjustments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/admin/orders/:id/adjustments/finalizeand/admin/orders/:id/adjustments/unfinalizeRef: #326 #321 #279
CC: @seantaylor @jhawthorn