Remove HABTMs from property prototypes#516
Merged
Merged
Conversation
We're working to remove HABTM relationships from the codebase for a variety of reasons, please see solidusio#289
cbrunsdon
force-pushed
the
habtm_prototypes
branch
from
6b30dcd to
c666b92
Compare
Contributor
|
|
👍, we almost always have to create models for these join tables at some point in time.
Member
|
I added a comment to #289 about a fix for a bug that was introduced with spree/spree#6654 |
Contributor
Author
|
@tvdeyen Hmm, thanks for the link, we'd only care about that where associations need to have their class's dynamically determined, right? I don't need to pay attention to that for this specific commit as neither specify the class nor is it dynamically determined, correct? |
Member
|
Yes,
I just wanted to be sure, that this is payed attention to ;)
|
Contributor
|
Don't forget those foreign keys :) @cbrunsdon thank you for taking over 👍 |
Contributor
Author
|
@BenMorganIO did I need the FK's to make this legit? I was trying to get the smallest possible improvement. Tests pass on this, after all... |
Contributor
|
@cbrunsdon 👍 then. |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
cbrunsdon
added a commit
that referenced
this pull request
Nov 24, 2015
Remove HABTMs from property prototypes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're working to remove HABTM relationships from the codebase for a
variety of reasons, please see #289
This is one PR in a series of me pulling apart and splitting up @BenMorganIO's work from #289