Validate order number uniqueness only when it changes

[ikraamg]

Solidus validates number uniqueness on every order save. The validation passes case_sensitive: true, which opts out of Rails' built-in skip for unchanged values, so the uniqueness query runs on every save, including each order recalculation.

This gates the uniqueness validation on number_changed? so it only runs on create and when the number changes.

• order recalculation drops from 4 queries to 2
• uniqueness is still enforced for new orders and for number changes
• adds specs covering both the enforcement and the skip

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (8d781ac) to head (3e6305d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6493   +/-   ##
=======================================
  Coverage   89.68%   89.69%           
=======================================
  Files         993      993           
  Lines       20863    20864    +1     
=======================================
+ Hits        18712    18713    +1     
  Misses       2151     2151           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tvdeyen]

Nice. Thank you