Avoid redundant queries when recalculating payment totals#6494
Open
ikraamg wants to merge 1 commit into
Open
Conversation
houndci-bot
reviewed
Jun 26, 2026
github-actions
Bot
added
the
changelog:solidus_core
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6494 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 993 993
Lines 20863 20863
=======================================
Hits 18712 18712
Misses 2151 2151 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Recalculating the payment total preloaded each payment's refunds but then summed them with a column-level sum, issuing one extra query per payment. Summing the already-loaded refunds keeps it to the single preload.
ikraamg
force-pushed
the
perf/payment-total-use-loaded-payments
branch
from
74f3f54 to
2d3081b
Compare
tvdeyen
approved these changes
Jun 26, 2026
tvdeyen
left a comment
tvdeyen
left a comment
Member
There was a problem hiding this comment.
Thanks! Please ignore the hound comments. We already removed the webhook and reached out to them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recalculating the payment total preloaded each payment's refunds with
includes(:refunds)but then summed them withrefunds.sum(:amount), which issues a separate query per payment instead of using the records already loaded.