Preload adjustments in promotion recalculation to avoid an N+1#6496
Open
ikraamg wants to merge 1 commit into
Open
Preload adjustments in promotion recalculation to avoid an N+1#6496ikraamg wants to merge 1 commit into
ikraamg wants to merge 1 commit into
Conversation
houndci-bot
reviewed
Jun 26, 2026
github-actions
Bot
added
changelog:solidus_legacy_promotions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6496 +/- ##
==========================================
- Coverage 89.68% 89.40% -0.29%
==========================================
Files 993 906 -87
Lines 20863 19208 -1655
==========================================
- Hits 18712 17172 -1540
+ Misses 2151 2036 -115 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Recalculating promotions loaded each line item's and shipment's adjustments with a separate query, so the adjustment query count grew with the number of items in the order. This runs on every order recalculation. Preloading the adjustments for all items in one batch keeps the query count constant regardless of order size. The same fix applies to both the legacy and the new promotion adjusters.
ikraamg
force-pushed
the
perf/promotion-adjustments-preload-n-plus-one
branch
from
a1d1c34 to
1eca826
Compare
houndci-bot
reviewed
Jun 26, 2026
| end | ||
|
|
||
| it "loads line item adjustments in a single query" do | ||
| expect { order_adjuster.call }.to make_database_queries(matching: /from .spree_adjustments..*adjustable_id. IN \(/im, count: 1) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [133/80]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recalculating promotions loaded each line item's and shipment's adjustments with its own query, so the adjustment query count grew with the number of items in the order. This runs on every order recalculation.