Preload variant and product when calculating taxes to avoid an N+1#6497
Open
ikraamg wants to merge 1 commit into
Open
Preload variant and product when calculating taxes to avoid an N+1#6497ikraamg wants to merge 1 commit into
ikraamg wants to merge 1 commit into
Conversation
houndci-bot
reviewed
Jun 26, 2026
github-actions
Bot
added
the
changelog:solidus_core
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6497 +/- ##
=======================================
Coverage 89.68% 89.69%
=======================================
Files 993 993
Lines 20863 20864 +1
=======================================
+ Hits 18712 18713 +1
Misses 2151 2151 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Calculating order taxes read each line item's tax category through its variant and, when the variant had none, through its product. With the associations unloaded that meant two queries per line item, every time taxes were recalculated. Preloading the variant and product for all line items keeps that load constant regardless of how many items the order has.
ikraamg
force-pushed
the
perf/tax-calculator-variant-product-preload
branch
from
2d68876 to
3adc5a8
Compare
houndci-bot
reviewed
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculating order taxes resolves each line item's tax category through its variant, falling back to the product when the variant has none. With those associations unloaded, that was two queries per line item, and taxes are recalculated on every order recalculation.