Eager load variant stock on the products API index to avoid an N+1#6501
Open
ikraamg wants to merge 1 commit into
Open
Eager load variant stock on the products API index to avoid an N+1#6501ikraamg wants to merge 1 commit into
ikraamg wants to merge 1 commit into
Conversation
The products API index rendered each variant's stock on hand without eager loading stock items, so the query count grew with the number of variants across the listed products. Eager loading stock items for the master, the variants, and the variants including master keeps the stock queries constant regardless of how many products and variants are listed.
houndci-bot
reviewed
Jun 26, 2026
github-actions
Bot
added
the
changelog:solidus_api
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6501 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 993 993
Lines 20863 20863
=======================================
Hits 18712 18712
Misses 2151 2151 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The products API index renders each variant's stock on hand, but did not eager load stock items, so the stock queries grew with the number of variants across the listed products. The page also loaded the master and the variants-including-master per product.