Conversation
|
/kick-ci |
|
/kick-ci |
|
Visit the preview URL for this PR (updated for commit a966c12): https://gloo-edge--pr10821-envoy-gloo-1-34-bump-ja9o87jq.web.app (expires Mon, 23 Jun 2025 15:10:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
…nvoy-gloo-1.34-bump
sam-heilbron
left a comment
sam-heilbron
left a comment
There was a problem hiding this comment.
As part of kgateway-dev#11191, there was an update to the go-control-plane as well, which I think makes sense to update the go types used by the proxy. I'm happy to approve as is, but can we make sure to include the go-control-palane update either in this PR or in a fast-follow?
|
Issues linked to changelog: |
go.mod
Outdated
| module github.com/solo-io/gloo | ||
|
|
||
| go 1.24.1 | ||
| go 1.24.2 |
There was a problem hiding this comment.
Any reason we don't upgrade to the latest patch release https://go.dev/doc/devel/release#go1.24.minor?
If we are updating, let's also include this in the changelog, and just be sure to make the same change in any downstream projects (ie solo-projects)
There was a problem hiding this comment.
good catch, didn't think of that. i was just copying the value from kgateway, but i'll update it to 1.24.4
| dependencyRepo: envoy-gloo | ||
| dependencyTag: 1.34.1-patch2 | ||
| - type: DEPENDENCY_BUMP | ||
| issueLink: |
There was a problem hiding this comment.
nit: empty link? we can likely just remove
4 participants
Description
Bump envoy-gloo to
v1.34.1-patch2v1.34.1-patch3solo-projects is passing CI on this pull request
Also pull in changes to the
devel/tools/changelog.shscriptAlso pull in go-control-plane bump from kgateway
API changes
Code changes
CI changes
Docs changes
Context
Interesting decisions
Testing steps
Notes for reviewers
Checklist: