Add BOM import scope enforcer rule#1
Merged
Conversation
Implements a custom Maven Enforcer rule (bomImportScopeRule) that ensures dependencies with type=pom (BOMs) always use scope=import. - BOMs in <dependencies> are always flagged (they belong in dependencyManagement) - BOMs in <dependencyManagement> without scope=import are flagged - Clear error messages listing all violations - Includes 9 unit tests covering all scenarios Co-Authored-By: lithium147@gmail.com <lithium147@gmail.com>
Co-Authored-By: lithium147@gmail.com <lithium147@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a custom Maven Enforcer rule (
bomImportScopeRule) that ensures dependencies withtype=pom(BOMs) always usescope=import.What it checks
<dependencies>are always flagged (they belong in<dependencyManagement>withscope=import)<dependencyManagement>withoutscope=importare flaggedFiles added
BomImportScopeRule.java— the enforcer rule implementation incom.solubris.enforcerBomImportScopeRuleTest.java— 9 unit tests covering all scenariosUsage
Link to Devin session: https://app.devin.ai/sessions/beab4575532748859e39706dd59d0848
Requested by: lithium147@gmail.com