checkProperty and checkExplicitVersion#2
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…-rule # Conflicts: # README.md # pom.xml # src/main/java/com/solubris/enforcer/ModelScanner.java # src/main/java/com/solubris/enforcer/UnusedPropertyRule.java # src/test/java/com/solubris/enforcer/VersionPropertyRuleTest.java
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| <groupId>org.junit.platform</groupId> | ||
| <artifactId>junit-platform-commons</artifactId> | ||
| <version>${junit.version}</version> | ||
| <version>6.0.3</version> |
There was a problem hiding this comment.
🟡 junit-platform-commons uses hardcoded version instead of ${junit.version} property
The PR changed junit-platform-commons version from ${junit.version} to the hardcoded literal 6.0.3, while junit-jupiter still uses ${junit.version} (which resolves to 6.0.3). This introduces inconsistency: two related JUnit dependencies now have mixed property/literal version references. This is precisely the pattern that the project's own VersionPropertyRule is designed to catch (unusedPropertyViolation - a property exists but is not used everywhere). Additionally, if junit.version is ever updated, junit-platform-commons will be left behind at the old version.
| <version>6.0.3</version> | |
| <version>${junit.version}</version> |
Was this helpful? React with 👍 or 👎 to provide feedback.
| <dependency> | ||
| <groupId>io.projectreactor</groupId> | ||
| <artifactId>reactor-core</artifactId> | ||
| <version>3.6.0</version> | ||
| </dependency> |
There was a problem hiding this comment.
🟡 reactor-core added as compile-scope dependency with no usage in the codebase
A new dependency io.projectreactor:reactor-core:3.6.0 was added without any <scope> element (defaulting to compile), but no code in the src/ directory references any Reactor classes (no imports of Flux, Mono, or any reactor.* package). This means reactor-core and all its transitive dependencies will be bundled into the published artifact unnecessarily, increasing its size and potentially causing classpath conflicts for consumers.
Was this helpful? React with 👍 or 👎 to provide feedback.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
1 participant
Uh oh!
There was an error while loading. Please reload this page.