-
-
Notifications
You must be signed in to change notification settings - Fork 410
Open
Labels
BugThings to squish; generally used for issuesThings to squish; generally used for issuesNeeds TriageIssues that need to be reviewed and categorizedIssues that need to be reviewed and categorized
Description
I was exploring the other day (don't remember what for, exactly) and the below constant + comment caught my attention enough to leave the file open.
Lines 77 to 78 in 6528e72
| IGNORE_RATE_LIMIT = 1 # equivalent to sopel.plugin.NOLIMIT | |
| """Return value used to indicate that rate-limiting should be ignored.""" |
Finally coming back to it now, I seriously wonder: Shouldn't this (plugins.rules.IGNORE_RATE_LIMIT) and plugin.NOLIMIT use the same value declaration, instead of relying on multiple assignments in different files to match? As in, plugin.NOLIMIT should be an alias to this value, not a separate declaration.
Clearly this isn't a priority, but I have started to think of it as a code smell of sorts.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
BugThings to squish; generally used for issuesThings to squish; generally used for issuesNeeds TriageIssues that need to be reviewed and categorizedIssues that need to be reviewed and categorized