-
Notifications
You must be signed in to change notification settings - Fork 203
fix(web): Fix text direction on filter panel #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughAdds a child-level LTR direction override via CSS for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/web/src/app/[domain]/search/components/filterPanel/entry.tsx (1)
55-55: Correct fix: child-level LTR wrapper enables proper rendering for C++/C# under left-truncationWrapping the text in a child element is the right approach to pair with
.truncate-start > * { direction: ltr; ... }and fixes the reversed-language issue without breaking left-side ellipsis.You can drop redundant classes because
truncate-startalready applieswhite-space: nowrap,overflow: hidden, andtext-overflow: ellipsis.-<p className="overflow-hidden text-ellipsis whitespace-nowrap truncate-start"><span>{displayName}</span></p> +<p className="truncate-start"><span>{displayName}</span></p>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
packages/web/src/app/[domain]/search/components/codePreviewPanel/codePreview.tsx(1 hunks)packages/web/src/app/[domain]/search/components/filterPanel/entry.tsx(1 hunks)packages/web/src/app/globals.css(1 hunks)packages/web/src/features/chat/components/chatThread/tools/shared.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*
📄 CodeRabbit Inference Engine (.cursor/rules/style.mdc)
Filenames should always be camelCase. Exception: if there are filenames in the same directory with a format other than camelCase, use that format to keep things consistent.
Files:
packages/web/src/app/[domain]/search/components/filterPanel/entry.tsxpackages/web/src/app/[domain]/search/components/codePreviewPanel/codePreview.tsxpackages/web/src/features/chat/components/chatThread/tools/shared.tsxpackages/web/src/app/globals.css
🔇 Additional comments (2)
packages/web/src/features/chat/components/chatThread/tools/shared.tsx (1)
35-35: LGTM: span wrapper aligns with the child-direction overrideThis pairs correctly with the new CSS rule to keep left-ellipsis behavior while rendering the path LTR inside the truncated container.
packages/web/src/app/[domain]/search/components/codePreviewPanel/codePreview.tsx (1)
224-224: LGTM: child span ensures correct LTR rendering inside left-truncation containerKeeps left-side ellipsis behavior intact and fixes symbol ordering (e.g., ++, #) in the header path. Retaining the title attribute for hover is a nice touch.
Fixes #463
Summary by CodeRabbit
Note
Improves readability and consistency of truncated paths/names, addressing RTL and special-character direction issues.
unicode-bidi: embed) for direct children oftruncate-start<span>withincodePreview.tsx, filter panelentry.tsx, and chat toolsshared.tsxto cooperate with truncationCHANGELOG.mdwith the fix entryWritten by Cursor Bugbot for commit 28e4624. This will update automatically on new commits. Configure here.