github: make it a Maintainer#158
Merged
varungandhi-src merged 1 commit intosourcegraph:masterfrom Jan 2, 2025
Merged
Conversation
In order to be a Maintainer, the GitHub Storage implementation must respond to `Maintain()`. Unlike all the other implementations, the GitHub implementation's Maintain() method was on the pointer receiver. This fix should allow the GitHub Storage implementation to be a Maintainer.
Contributor
Author
|
@varungandhi-src Happy New Year. Would you mind taking a look at this change? Thanks! |
Contributor
Author
|
Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be a Maintainer, the GitHub Storage implementation must respond to
Maintain(). Unlike all the other implementations, the GitHub implementation's Maintain() method was on the pointer receiver. This fix should allow the GitHub Storage implementation to be a Maintainer.As a side note, it'd be nice to have a setting for this somewhere in case someone wants to keep all their history.