insights: set PGDATA=/var/lib/postgresql/data/pgdata#269
Merged
Conversation
I previously thought `PGDATA=/var/lib/postgresql/data/pgdata` was the default, but it is definitely not: `/var/lib/postgresql/data` is. I removed this from `deploy-codeinsights-db.sh` for consistency with the Docker Compose deployment, but this would have broken existing pure-docker deployments because they were storing data in the `pgdata` subdirectory previously. I have added this to Docker Compose deployments here, for consistency, although it is not strictly required (Docker Compose volumes, unlike Kubernetes ones, do not appear ot have a `lost+found` file in them and as such Postgres is happy to use the root of the volume - whereas in Kubernetes deployments it will complain the directory is not empty and fail to start.) Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
emidoots
pushed a commit
to sourcegraph/deploy-sourcegraph
that referenced
this pull request
Feb 26, 2021
See sourcegraph/deploy-sourcegraph-docker#269 Signed-off-by: Stephen Gutekanst <stephen@sourcegraph.com>
ggilmore
approved these changes
Feb 26, 2021
davejrt
approved these changes
Feb 26, 2021
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously thought
PGDATA=/var/lib/postgresql/data/pgdatawas the default,but it is definitely not:
/var/lib/postgresql/datais.I removed this from
deploy-codeinsights-db.shfor consistency with the DockerCompose deployment, but this would have broken existing pure-docker deployments
because they were storing data in the
pgdatasubdirectory previously.I have added this to Docker Compose deployments here, for consistency, although
it is not strictly required (Docker Compose volumes, unlike Kubernetes ones, do
not appear ot have a
lost+foundfile in them and as such Postgres is happy touse the root of the volume - whereas in Kubernetes deployments it will complain
the directory is not empty and fail to start.)
Signed-off-by: Stephen Gutekanst stephen@sourcegraph.com
Checklist