This repository was archived by the owner on Mar 5, 2026. It is now read-only.
Manual Stable Release#1862
Merged
Merged
Conversation
mkondratek
force-pushed
the
mkondratek/chore/manual-stable-release
branch
from
9588145 to
6b277ed
Compare
mkondratek
commented
Jul 2, 2024
| @@ -117,28 +117,33 @@ After doing that: | |||
|
|
|||
| ## Publishing a New Release | |||
Contributor
Author
There was a problem hiding this comment.
odisseus
reviewed
Jul 2, 2024
dominiccooney
approved these changes
Jul 3, 2024
dominiccooney
left a comment
dominiccooney
left a comment
There was a problem hiding this comment.
LGTM
Agree with @odisseus that the -nightly suffix check can be simplified
Some more feedback inline
| @@ -1,10 +1,4 @@ | |||
| #!/usr/bin/env bash | |||
| # This script implements the time-based version scheme from RFC 795 | |||
There was a problem hiding this comment.
Why delete this, particularly since client releases are moving to be more aligned with Sourcegraph releases, not less?
Contributor
Author
There was a problem hiding this comment.
The script does not work like the comment says. Also, we wanted "prettier" version numbers for GA.
odisseus
approved these changes
Jul 3, 2024
steveyegge
pushed a commit
that referenced
this pull request
Jul 9, 2024
Our current setup produces a lot of stable releases that often are not unhidden eventually. That makes the QA and awaiting JB approval process parallel. Based on the recent experience only 1/8 releases goes public. That is a waste of JB approval team's time and CI time. Let's change the setup. The nightly version handling does not change but the default release script does not longer publish the stable version. Instead the separate workflow can be triggered on the specific tag that publishes the stable version. ## Test plan 1. push a tag for a nightly release 2. trigger the stable release manually to be tested once merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current setup produces a lot of stable releases that often are not unhidden eventually. That makes the QA and awaiting JB approval process parallel. Based on the recent experience only 1/8 releases goes public. That is a waste of JB approval team's time and CI time.
Let's change the setup. The nightly version handling does not change but the default release script does not longer publish the stable version. Instead the separate workflow can be triggered on the specific tag that publishes the stable version.
Test plan
to be tested once merged