Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

Show the login screen when the token is missing#1867

Merged
mkondratek merged 1 commit into
mainfrom
mkondratek/fix/missing-token-show-login
Jul 3, 2024
Merged

Show the login screen when the token is missing#1867
mkondratek merged 1 commit into
mainfrom
mkondratek/fix/missing-token-show-login

Conversation

@mkondratek

@mkondratek mkondratek commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Test plan

Delete the token from the keychain externally
You can run a separate instance of IDE and remove the account there.

  1. Log in to the account
  2. Open another IDE, log in to the same account, apply, then remove the account, apply
  3. Switch back to the first ide
  4. Close and reopen the project
  5. Login panel visible

@mkondratek mkondratek self-assigned this Jul 2, 2024

@pkukielka pkukielka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek merged commit be7f46f into main Jul 3, 2024
@mkondratek mkondratek deleted the mkondratek/fix/missing-token-show-login branch July 3, 2024 08:09
steveyegge pushed a commit that referenced this pull request Jul 9, 2024
## Test plan
Delete the token from the keychain externally 
You can run a separate instance of IDE and remove the account there.

1. Log in to the account
2. Open another IDE, log in to the same account, apply, then remove the
account, apply
3. Switch back to the first ide
4. Close and reopen the project
5. Login panel visible
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants