Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

Add proper groups for Cody actions#1884

Merged
pkukielka merged 2 commits into
mainfrom
pkukielka/organise-keymap
Jul 5, 2024
Merged

Add proper groups for Cody actions#1884
pkukielka merged 2 commits into
mainfrom
pkukielka/organise-keymap

Conversation

@pkukielka

Copy link
Copy Markdown
Contributor

Closes https://linear.app/sourcegraph/issue/CODY-2095/organize-keymap-settings

Changes

  1. Proper grouping was added for all actions in plugin.xml
  2. The same grouping is used for nice visual organisation of keymap management

Test plan

Visual verification in Settings > Keymap (see screenshots):

image
image

@danielmarquespt

Copy link
Copy Markdown
Contributor

@pkukielka Looks good!

Small nit: Can you put the Sourcegraph group after Cody Accounts? Not a major thing

@pkukielka

Copy link
Copy Markdown
Contributor Author

@pkukielka Looks good!

Small nit: Can you put the Sourcegraph group after Cody Accounts? Not a major thing

Done!

@pkukielka pkukielka enabled auto-merge (squash) July 5, 2024 07:37
}

private void createTitleActions(@NotNull List<? super AnAction> titleActions) {
AnAction action = ActionManager.getInstance().getAction("CodyChatActionsGroup");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before it was an action group, now it's an action - does it still work?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it before changing - it work just fine :)

@pkukielka pkukielka merged commit b9dd57e into main Jul 5, 2024
@pkukielka pkukielka deleted the pkukielka/organise-keymap branch July 5, 2024 09:26
steveyegge pushed a commit that referenced this pull request Jul 9, 2024
Closes
https://linear.app/sourcegraph/issue/CODY-2095/organize-keymap-settings

## Changes

1. Proper grouping was added for all actions in plugin.xml
2. The same grouping is used for nice visual organisation of keymap
management

## Test plan

Visual verification in `Settings > Keymap` (see screenshots):


![image](https://github.com/sourcegraph/jetbrains/assets/1519649/b5292cfb-5a2f-47ae-9706-512fb2675b8a)

![image](https://github.com/sourcegraph/jetbrains/assets/1519649/5553077a-c21e-4003-b1c8-0c2f279f6467)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants