This repository was archived by the owner on Mar 5, 2026. It is now read-only.
Revert "feat(uninstall): delete auth credentials on uninstall (CODY-1043) (#2434)"#2484
Merged
Conversation
jamesmcnamara
changed the title
dominiccooney
approved these changes
Oct 19, 2024
dominiccooney
left a comment
dominiccooney
left a comment
There was a problem hiding this comment.
LGTM
believe the test failures are unrelated flakes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 65f65c5.
The UninstallListener introduced in this commit seems to run for every extension uninstall instead of just when the sourcegraph extension is uninstalled.
Test plan
This will need to be manually tested.