Fix plugin for Scala 3 projects #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our previous logic relied on withDefaultValue in the Scalameta version
map to get the version of scalameta plugin.
Issue is, withDefaultValue does not affect .get operations:
```scala
Welcome to Scala 2.12.18 (OpenJDK 64-Bit Server VM, Java 17.0.6).
Type in expressions for evaluation. Or try :help.
scala> val mp = Map("a" -> 2).withDefaultValue(3)
mp: scala.collection.immutable.Map[String,Int] = Map(a -> 2)
scala> mp.get("c")
res0: Option[Int] = None
```
Moreover, we don't need to add semanticdb plugin at all if we're working
on a Scala 3 project.
This comment fixes the logic to be explicit about Scala 3.
Additionally, we amend the semanticdb parameters used to customise
output location, according to https://github.com/sbt/sbt/blob/1.9.x/main/src/main/scala/sbt/plugins/SemanticdbPlugin.scala#L92
1. Remove Java 17-ism 2. Upgrade SBT to 1.9.3 3. Remove sbt-bloop (it's added automatically by metals)
Merged
olafurpg
approved these changes
Aug 15, 2023
Contributor
olafurpg
left a comment
olafurpg
left a comment
There was a problem hiding this comment.
LGTM 👍🏻 Nice to get this working with Scala 3!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that Scala 3 projects don't work, and identified the issue (semanticdb location calculation).
Working on a fix currently
Test plan