Gradle: improve dependency detection #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
reviewed
Mar 30, 2023
tests/buildTools/src/test/scala/tests/GradleBuildToolSuite.scala
Outdated
Show resolved
Hide resolved
Strum355
approved these changes
Mar 30, 2023
olafurpg
force-pushed
the
olafurpg/marklogic
branch
from
b7a2daa to
46dad69
Compare
Previously, `scip-java index` didn't correctly identify all dependencies of Gradle builds. This PR changes the dependency detection script to collect more dependencies resultin in more accurate cross-repo navigation.
olafurpg
force-pushed
the
olafurpg/marklogic
branch
from
089bb23 to
247fd34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
scip-java indexdidn't correctly identify all dependenciesof Gradle builds. This PR changes the dependency detection script to
collect more dependencies resultin in more accurate cross-repo
navigation.
Test plan
See new test case, which I manually verified fails on
main.