Add is_reference relationships between synthetic case class symbols
#561
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,37 +4,52 @@ package minimized | |
| case class Issue396(a: Int) | ||
| // ^^^^^^^^ definition semanticdb maven . . minimized/Issue396# | ||
| // documentation ```scala\ncase class Issue396(a: Int)\n``` | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396. | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396.apply(). | ||
| // ________ synthetic_definition semanticdb maven . . minimized/Issue396#copy(). | ||
| // documentation ```scala\ndef copy(a: Int): Issue396\n``` | ||
| // relationship is_definition semanticdb maven . . minimized/Issue396# | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396.apply(). | ||
| // ________ synthetic_definition semanticdb maven . . minimized/Issue396#productElement(). | ||
| // documentation ```scala\ndef productElement(x$1: Int): Any\n``` | ||
| // relationship is_definition semanticdb maven . . minimized/Issue396# | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396.apply(). | ||
|
Contributor
There was a problem hiding this comment. Lifting from slack: both @olafurpg and I agree that productElement* family of methods shouldn't be referencing apply
|
||
| // relationship is_reference is_implementation semanticdb maven . . scala/Product#productElement(). | ||
| // ________ synthetic_definition semanticdb maven . . minimized/Issue396. | ||
| // documentation ```scala\nobject Issue396\n``` | ||
| // relationship is_definition semanticdb maven . . minimized/Issue396# | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396.apply(). | ||
| // ________ synthetic_definition semanticdb maven . . minimized/Issue396.apply(). | ||
| // documentation ```scala\ndef apply(a: Int): Issue396\n``` | ||
| // relationship is_definition semanticdb maven . . minimized/Issue396# | ||
| // relationship is_reference is_implementation semanticdb maven . . scala/Function1#apply(). | ||
| // ________ synthetic_definition semanticdb maven . . minimized/Issue396#productElementName(). | ||
| // documentation ```scala\ndef productElementName(x$1: Int): String\n``` | ||
| // relationship is_definition semanticdb maven . . minimized/Issue396# | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396.apply(). | ||
| // relationship is_reference is_implementation semanticdb maven . . scala/Product#productElementName(). | ||
| // ^ definition semanticdb maven . . minimized/Issue396#`<init>`(). | ||
| // documentation ```scala\ndef this(a: Int)\n``` | ||
| // ^ definition semanticdb maven . . minimized/Issue396#a. | ||
| // documentation ```scala\nval a: Int\n``` | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396#`<init>`().(a) | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396#copy().(a) | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396.apply().(a) | ||
| // _ synthetic_definition semanticdb maven . . minimized/Issue396.apply().(a) | ||
| // documentation ```scala\na: Int \n``` | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396#`<init>`().(a) | ||
| // relationship is_reference is_definition semanticdb maven . . minimized/Issue396#a. | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396#copy().(a) | ||
| // _ synthetic_definition semanticdb maven . . minimized/Issue396#`<init>`().(a) | ||
| // documentation ```scala\na: Int \n``` | ||
| // relationship is_reference is_definition semanticdb maven . . minimized/Issue396#a. | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396#copy().(a) | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396.apply().(a) | ||
| // _ synthetic_definition semanticdb maven . . minimized/Issue396#copy().(a) | ||
| // documentation ```scala\ndefault a: Int \n``` | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396#`<init>`().(a) | ||
| // relationship is_reference is_definition semanticdb maven . . minimized/Issue396#a. | ||
| // relationship is_reference semanticdb maven . . minimized/Issue396.apply().(a) | ||
| // ^^^ reference semanticdb maven . . scala/Int# | ||
| object Issue396App { | ||
| // ^^^^^^^^^^^ definition semanticdb maven . . minimized/Issue396App. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of the changes aside, let's bikeshed about this for a few days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have format on save enabled in VS Code and 🤷🏻 Worth adding a CI check to format the YAML files with prettier