Fix bugs in Gradle integration #684
Conversation
javac seems to consider that an error, and it can happen if there are multiple java compilation tasks
keynmol
changed the title
| private object Logging { | ||
| def info(msg: Any*) = | ||
| System.err.println(s"[INFO] [scip-java.gradle] ${msg.mkString(" ")}") | ||
|
|
||
| def warn(msg: Any*) = | ||
| System.err.println(s"[INFO] [scip-java.gradle] ${msg.mkString(" ")}") | ||
|
|
||
| } |
There was a problem hiding this comment.
Mildly surprised that we didn't already have a standard logging functionality, given the amount of logging we have in scip-clang, I'm guessing it's not a problem here because things mostly just work?
There was a problem hiding this comment.
because things mostly just work
god no, things mostly don't :D
But the problem is that all failures come from Gradle and from unexpected places, and so far there hasn't been a single case where there was some sort of information we could query from Gradle that would allow us to log it and debug remotely.
So logging doesn't really help - the warnings here are for customers mostly.
There was a problem hiding this comment.
Going forward I do want to identify bits of information that could guide investigations and log them preemptively.
semanticdb-gradle-plugin/src/main/scala/SemanticdbGradlePlugin.scala
Outdated
Show resolved
Hide resolved
….scala Co-authored-by: Varun Gandhi <varun.gandhi@sourcegraph.com>
Fix two bugs in Gradle plugin.
Test plan
Reproducing both failures seems difficult as I've only spotted them while working on indexing spring codebase.