This repository was archived by the owner on Sep 30, 2024. It is now read-only.
use tslint rules for React hooks linting#3517
Closed
sqs wants to merge 1 commit into
Closed
Conversation
Uses https://github.com/Gelio/tslint-react-hooks for linting React hooks code to find common mistakes, as recommended by https://reactjs.org/docs/hooks-rules.html. Addresses sourcegraph/sourcegraph#3392 (comment). Note: We plan to switch from TSLint to ESLint soon (sourcegraph/sourcegraph#2461). In that case, we will use the more standard ESLint rules for React hooks instead. Confirmed working; if I add a `useEffect` in an if-statement, it reports: ``` /home/sqs/src/github.com/sourcegraph/sourcegraph/shared/src/components/linkPreviews/WithLinkPreviews.tsx:27:9 ERROR: 27:9 react-hooks-nesting A hook cannot appear inside an if statement ```
1 task
Codecov Report
|
felixfbecker
left a comment
felixfbecker
left a comment
Contributor
There was a problem hiding this comment.
Any reason to not add this to our shared TSLint config?
Member
Author
|
@felixfbecker No, good call. Closing this in favor of sourcegraph/tslint-config#9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses https://github.com/Gelio/tslint-react-hooks for linting React hooks code to find common mistakes, as recommended by https://reactjs.org/docs/hooks-rules.html.
Addresses https://github.com/sourcegraph/sourcegraph/pull/3392#discussion_r275895266.
Note: We plan to switch from TSLint to ESLint soon (https://github.com/sourcegraph/sourcegraph/issues/2461). In that case, we will use the more standard ESLint rules for React hooks instead.
Confirmed working; if I add a
useEffectin an if-statement, it reports: