This repository was archived by the owner on Mar 10, 2022. It is now read-only.
Default remote setting#110
Closed
matthewnitschke wants to merge 8 commits into
Closed
Conversation
matthewnitschke
commented
Sep 27, 2020
Comment on lines
+12
to
+16
| { | ||
| "type": "npm", | ||
| "label": "build", | ||
| "script": "build", | ||
| }, |
Author
There was a problem hiding this comment.
Running the Launch Setting task resulted in an error. Adding this task fixed the issue
Author
|
@nicksnyder @felixfbecker Could someone take a look at this? |
nicksnyder
reviewed
Nov 12, 2020
nicksnyder
requested review from
a team,
felixfbecker and
marekweb
and removed request for
a team
Contributor
|
seems safe to merge, @sourcegraph/web can you own this? |
Author
|
Closing as I feel: #122 is a better solution to the problem @nicksnyder Can someone take a look at that pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When multiple remotes are returned from
git remote, this extension defaults to using the first returned remote name. This can be frustrating when the first remote name is not the desired remote to use.Changes
Adds a
sourcegraph.defaultRemotesetting to enable specifying a static remote that can be use. Whensourcegraph.defaultRemoteis null (the default setting value), the old remote logic is used.