Skip to content
This repository was archived by the owner on Mar 10, 2022. It is now read-only.

fix: scenario where branchPosition is not in upstream#162

Merged
tjkandala merged 3 commits into
sourcegraph:masterfrom
alexschneider:alexschneider/failing-test-branch-not-pushed-upstream
Apr 5, 2021
Merged

fix: scenario where branchPosition is not in upstream#162
tjkandala merged 3 commits into
sourcegraph:masterfrom
alexschneider:alexschneider/failing-test-branch-not-pushed-upstream

Conversation

@alexschneider

Copy link
Copy Markdown
Contributor

When upstream is set to origin/master a bug in the code sets the maybeRemote to origin/mast if the branch isn't found due to how lastIndexOf works. This fixes the issue.

@alexschneider alexschneider changed the title Fix scenario where branchPosition is not in upstream fix: scenario where branchPosition is not in upstream Apr 5, 2021
@tjkandala

Copy link
Copy Markdown
Contributor

Thanks!

@tjkandala tjkandala merged commit eddb761 into sourcegraph:master Apr 5, 2021
@github-actions

github-actions Bot commented Apr 5, 2021

Copy link
Copy Markdown

🎉 This PR is included in version 1.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants