java_home doesn't honor role attributes

[samperman]

I've created a role that sets the jdk_version and install_flavor. It results int he correct version of java being installed, but the JAVA_HOME results in some strange directory names.

The role looks like this:

{
  "name": "javatest",
  "description": "Test starting java",
  "json_class": "Chef::Role",
  "chef_type": "role",
  "override_attributes": {
    "java": {
      "jdk_version": 7,
      "install_flavor": "oracle",
      "oracle": {
        "accept_oracle_download_terms": true
      }
    }
  },
  "run_list": [
    "recipe[apt::default]",
    "recipe[java]"
  ]
}

Here is an ssh session that shows that JAVA_HOME points to a very confusingly named directory.

vagrant@ubuntu-vagrant:~$ echo $JAVA_HOME
/usr/lib/jvm/java-6-openjdk-amd64
vagrant@ubuntu-vagrant:~$ ll /usr/lib/jvm/
total 16
drwxr-xr-x  3 root root 4096 Dec 15 21:54 ./
drwxr-xr-x 51 root root 4096 Dec 15 21:53 ../
lrwxrwxrwx  1 root root   24 Dec 15 21:54 java-6-openjdk-amd64 -> /usr/lib/jvm/jdk1.7.0_25/
-rw-------  1 root root 2594 Dec 15 21:54 .java-6-openjdk-amd64.jinfo
drwxr-xr-x  8  500  143 4096 Jun  6  2013 jdk1.7.0_25/
vagrant@ubuntu-vagrant:~$ cat /etc/profile.d/jdk.sh
export JAVA_HOME=/usr/lib/jvm/java-6-openjdk-amd64vagrant@ubuntu-vagrant:~$
vagrant@ubuntu-vagrant:~$ java -version
java version "1.7.0_25"
Java(TM) SE Runtime Environment (build 1.7.0_25-b15)
Java HotSpot(TM) 64-Bit Server VM (build 23.25-b01, mixed mode)

Am I setting the attributes incorrectly?

[samperman]

It looks like this is happening because java/attribibutes/default.rb is computing the value of node['java']['java_home'] before my override values take effect. This leaves java_home in a bad state.

I've working around this issue by creating my own cookbook that depends on your cookbook but adds the following block first:

# java_home may have been computed too early. reload the attributes to fix it
b = ruby_block 'reset_java_home' do
  block do
    node.load_attribute_by_short_filename('default', 'java')
  end
  action :nothing
end

# run this action immediately. if I don't do this it either never runs (action :nothing)
# or runs too late (action :create)
b.run_action(:create)

Maybe java_home should be computed inside the recipe after all attribute overrides have been applied?

[carmstrong]

What version of the cookbook are you using? I'm wondering if you see the same behavior with the latest, 1.16.2. If not, this is definitely a bug - JAVA_HOME should most certainly match the jdk you're actually using :(

[samperman]

This was with version 1.15.4.

I'm wondering if (pull request 95)[https://github.com//pull/95] will fix this issue though. It looks like it.

[carmstrong]

Yeah, that's what I was thinking. If you're still seeing issues after upgrading, there's a bug to fix.

[samperman]

Looks like it is fixed in 1.16.2.

[mylons]

@samperman it does sound like #95 would fix this -- it's one of the reasons I submitted that request

[samperman]

Thanks for the fix!

[carmstrong]

Glad this is sorted!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.