TOK-455#327
Merged
cam-parra merged 6 commits intosovrin-foundation:masterfrom Oct 23, 2018
mattraffel:master
Merged
Conversation
added 2 commits
October 22, 2018 13:56
Signed-off-by: matt raffel <matt.raffel@evernym.com>
Signed-off-by: matt raffel <matt.raffel@evernym.com>
cam-parra
previously approved these changes
Oct 23, 2018
Contributor
dastardlychimp
left a comment
dastardlychimp
left a comment
There was a problem hiding this comment.
I would like changes to use the setup minting.
num_addresses: 2,
mint_tokens: vec![30, 50],
The tokens are mapped with the generated addresses.
| let tokens : i32 = 50; | ||
|
|
||
| // ---- create some tokens | ||
| do_minting(pool_handle, &wallet, &dids, &payment_addresses[0], tokens); |
Contributor
There was a problem hiding this comment.
You can do minting as part of the Setup/SetupConfig, so you don't need to have this do_minting function.
|
|
||
| match indy::payments::Payment::build_payment_req(wallet.handle, Some(dids[0]), &pay_input_json, &pay_output_json, None) { | ||
| Ok(_) => { assert!(false, "Expected CommonInvalidStructure error"); } | ||
| Err(ec) => { assert_eq!(ec, ErrorCode::CommonInvalidStructure); } |
Contributor
There was a problem hiding this comment.
You could use an assert_eq! assertion which is a little more condensed.
let ec = (...).unwrap_err();
assert_eq!(ErrorCode::CommonInvalidStructure, ec);
or
assert_eq!(Err(ErrorCode::CommonInvalidStructure), result);
Contributor
Author
There was a problem hiding this comment.
much better. thnx
Signed-off-by: matt raffel <matt.raffel@evernym.com>
added 2 commits
October 23, 2018 13:14
… functionality Signed-off-by: matt raffel <matt.raffel@evernym.com>
Signed-off-by: matt raffel <matt.raffel@evernym.com>
dastardlychimp
previously approved these changes
Oct 23, 2018
Signed-off-by: matt raffel <matt.raffel@evernym.com>
dastardlychimp
approved these changes
Oct 23, 2018
cam-parra
approved these changes
Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cases to test