fix: require_mention falls through to default agent instead of dropping message

[jamiepine]

Summary

• require_mention has never worked — when a binding rejected a message due to missing mention, resolve_agent_for_message fell through to the default agent and processed it anyway
• The check was also hardcoded to Discord only; Telegram, Slack, and Twitch silently ignored the setting

Changes

src/config/types.rs — Split matches() into matches_route() (routing criteria) and passes_require_mention() (mention filter). Made passes_require_mention platform-agnostic using each adapter's *_mentions_or_replies_to_bot metadata key. Changed resolve_agent_for_message to return Option<AgentId> — returns None when a binding matched on routing but was blocked by require_mention, so the message is dropped instead of falling through.

src/messaging/telegram.rs — Added telegram_mentions_or_replies_to_bot metadata key (Telegram was the only adapter missing a combined mention/reply flag). Checks both @botusername text mentions and reply-to-bot.

src/main.rs — Handle the None return with continue to drop suppressed messages.

Repro

With this config, the bot responds to every message in the bound channels despite require_mention = true:

[[bindings]]
agent_id = "spacedrive-discord"
channel = "discord"
channel_ids = ["1475586817456607353"]
guild_id = "949090953497567312"
require_mention = true

The binding rejects the message → falls through to default_agent_id ("main") → main processes it with no mention requirement.

Note

Fix Summary: This PR fixes the require_mention feature which was broken in two ways: mentioning only checks Discord and only as a routing filter, causing unmentioned messages to fall through to the default agent instead of being dropped. Now the check is platform-agnostic and properly suppresses messages before they reach fallback handling. Telegram adapter gains mention detection for the first time.

_{Written by Tembo for commit badee64. This will update automatically on new commits.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 99c35f30-56da-4829-89ec-c55b7100a909

📥 Commits

Reviewing files that changed from the base of the PR and between 5afbe63 and 3cd71b2.

📒 Files selected for processing (2)

• src/config/types.rs
• src/messaging/telegram.rs

🚧 Files skipped from review as they are similar to previous changes (2)

• src/config/types.rs
• src/messaging/telegram.rs

---

Walkthrough

Binding matching split into routing-only checks (matches_route) and a separate passes_require_mention filter; resolve_agent_for_message now returns Option<AgentId> and can suppress matches blocked by require_mention. Main loop handles the Option and drops suppressed messages. Telegram metadata now records combined mention-or-reply-to-bot state.

Changes

Cohort / File(s)	Summary
Binding resolution refactor src/config/types.rs	Renamed matches → matches_route for routing checks; added private passes_require_mention(&self, message) enforcing require_mention (with DM exceptions); resolve_agent_for_message now returns Option<AgentId> and returns None when mention requirement blocks a route; updated comments.
Main loop update src/main.rs	Adjusted inbound message handling to pattern-match the Option<AgentId> from resolve_agent_for_message, early-continue when None, and proceed using Some(agent_id).
Telegram metadata src/messaging/telegram.rs	Added detection of telegram_mentions_or_replies_to_bot by combining text mention scanning and reply-to-bot matching; inserts the combined flag into message metadata.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the primary fix: require_mention was falling through to the default agent instead of dropping messages, which is the core issue addressed in the changeset.
Description check	✅ Passed	The description is well-related to the changeset, clearly explaining the problem, solution, and affected files, with a concrete reproduction example and detailed explanation of the fix.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/require-mention-fallthrough

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tembo]

contains_key("discord_guild_id") treats null as present, so a DM could get misclassified and blocked when require_mention is on. Safer to mirror the old as_u64().is_some() behavior.

Suggested change

	message.source == "discord" && !message.metadata.contains_key("discord_guild_id");
	let is_dm = message.source == "discord"
	&& message
	.metadata
	.get("discord_guild_id")
	.and_then(|v| v.as_u64())
	.is_none();

[tembo]

Small nit: this comment says mentions come via entities, but the implementation is a case-insensitive substring search on extracted text/caption. Either parse entities, or tweak the comment to match what’s happening.

Suggested change

	// Check text-based @mention (Telegram sends mentions as entities)
	// Check text-based @mention in message text/caption.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/config/types.rs`:
- Around line 1541-1545: The DM-bypass only checks Discord; update the DM
detection to also recognize Telegram private chats so require_mention bindings
won't drop them: extend the is_dm condition (the variable named is_dm in this
code) to return true when message.source == "telegram" and message.metadata
contains telegram_chat_type == "private" (and/or when
telegram_mentions_or_replies_to_bot metadata is present/false for ordinary DM
text), then keep the existing early return; locate and modify the is_dm logic
that currently inspects message.source and message.metadata to include these
Telegram metadata keys.

In `@src/messaging/telegram.rs`:
- Around line 865-873: The code uses text_lower.contains(&mention) which allows
prefix matches like "@spacebot_extra"; instead, update the mention detection to
use Telegram entities or a username-boundary check: in the message handling
where you use bot_username, extract_text, and set mentions_or_replies_to_bot,
iterate message.entities (or parse MessageEntity entries) for
Mention/TextMention and compare the entity text (case-insensitive) to the exact
bot username, or if entities are not available, scan the text for occurrences of
"@{bot_username}" and ensure the character after the matched username is absent
or not in [A-Za-z0-9_] (and the char before is start or non-word) so you only
match whole Telegram usernames.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 294ac00c-b626-4e6a-8eee-b3044b3728bd

📥 Commits

Reviewing files that changed from the base of the PR and between a5eba12 and badee64.

📒 Files selected for processing (3)

• src/config/types.rs
• src/main.rs
• src/messaging/telegram.rs