Skip to content

Fix detection of redhat enterprise compute node#15253

Merged
adamjstewart merged 3 commits into
spack:developfrom
adamjstewart:fixes/rhel
Feb 28, 2020
Merged

Fix detection of redhat enterprise compute node#15253
adamjstewart merged 3 commits into
spack:developfrom
adamjstewart:fixes/rhel

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

@CreRecombinase can you check if this solves #15251 for you?

We need to upstream this to the distro project if it doesn't already exist in newer versions of distro.

@CreRecombinase
Copy link
Copy Markdown
Contributor

As far as I can tell this works. Thanks so much!

@scheibelp
Copy link
Copy Markdown
Member

We need to upstream this to the distro project if it doesn't already exist in newer versions of distro.

I don't see it in https://github.com/nir0s/distro/blob/master/distro.py

Do you think it's worth waiting to open a PR there before merging this?

We've had other issues like this in the past (e.g. conversion of OS names between minor releases of an OS). IMO it would be good to have a configuration option in Spack for converting one form of detected OS into another. Do you agree?

@adamjstewart
Copy link
Copy Markdown
Member Author

@scheibelp I opened a PR at python-distro/distro#255

We've had other issues like this in the past (e.g. conversion of OS names between minor releases of an OS). IMO it would be good to have a configuration option in Spack for converting one form of detected OS into another. Do you agree?

Conversion of OS names is already being done by distro itself, I don't think it would be a good idea to have our own logic to do that too. The distro developers have been pretty good about these changes in the past, see python-distro/distro#165

@adamjstewart adamjstewart merged commit 513f923 into spack:develop Feb 28, 2020
@adamjstewart adamjstewart deleted the fixes/rhel branch February 28, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants