Merged
Conversation
The return value of xmlC14NExecute was not being checked, so canonicalization failures (e.g., relative namespace URIs) silently returned an empty string. This could allow downstream libraries to accept invalid canonicalized output. Check the return value and raise RuntimeError on failure, matching JRuby's existing behavior. This behavior was named as a contributing cause to GHSA-x4h9-gwv3-r4m4
flavorjones
force-pushed
the
c14n-raise-on-failure
branch
from
3584640 to
5b77f3d
Compare
flavorjones
added a commit
that referenced
this pull request
Feb 17, 2026
Forward port of #3600 to main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Canonicalization could fail and an exception would not be raised. This behavior was named as a contributing cause in ruby-saml GHSA-x4h9-gwv3-r4m4
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
JRuby raised an exception correctly already. This bring the CRuby implementation in line.