This repository was archived by the owner on May 7, 2025. It is now read-only.
Identifier hotfix#16
Merged
Merged
Conversation
danielduhh
approved these changes
Aug 2, 2019
Contributor
danielduhh
left a comment
danielduhh
left a comment
There was a problem hiding this comment.
Nice fix. Let’s create an issue to fix this in the future
MonicaBrandeis
approved these changes
Aug 2, 2019
MonicaBrandeis
left a comment
MonicaBrandeis
left a comment
There was a problem hiding this comment.
Nice work and needed fixes, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR to atlas-checks changed atlas identifiers from
ItemIdtoidentifierand OSM identifiers fromosmidtoosmIdentifier, which breaks this tool.Happy to discuss a longer-term solution that involves checking both but for now we'd like to be able to run this on the most recent data that gets generated by atlas-checks.
I verified that
mqmstarts to run after these changes were made: