[WIP] add float32 support for all kernels - #42
Open
dshaaban01 wants to merge 2 commits into
Open
Conversation
dshaaban01
changed the title
dshaaban01
marked this pull request as draft
December 17, 2025 17:27
|
We currently marked this PR as WIP due to being unsure what the default should be. Should the default be that all kernels run on |
dshaaban01
marked this pull request as ready for review
December 17, 2025 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for float32 to all kernels. Most kernels work fine, however some fail to validate, and some others don't actually do calculations in float64.
This PR also changes the default precision to float32 in all kernels with floating-point precision.