Exclude hidden and deprecated commands from usage padding calculation#2373
Open
kovan wants to merge 1 commit intospf13:mainfrom
Open
Exclude hidden and deprecated commands from usage padding calculation#2373kovan wants to merge 1 commit intospf13:mainfrom
kovan wants to merge 1 commit intospf13:mainfrom
Conversation
Hidden and deprecated commands are not shown in usage output, but their names were included when calculating the maximum column widths for formatting. This caused unnecessary padding when a hidden or deprecated command had a longer name than any visible command. Skip hidden and deprecated commands in both AddCommand and RemoveCommand when computing commandsMaxUseLen, commandsMaxCommandPathLen, and commandsMaxNameLen. Fixes spf13#1272
|
|
ccoVeille
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hidden and deprecated commands are not shown in usage output, but their names were included when calculating the maximum column widths for formatting. This caused unnecessary extra padding when a hidden or deprecated command had a longer name than any visible command.
This PR skips hidden and deprecated commands in both
AddCommandandRemoveCommandwhen computingcommandsMaxUseLen,commandsMaxCommandPathLen, andcommandsMaxNameLen.Continues the work from stale PR #1632 (open since 2022, no activity since November 2022).
Fixes #1272