Add IPNetSlice and unit tests#170
Conversation
|
|
| func (s *ipNetSliceValue) Set(val string) error { | ||
|
|
||
| // remove all quote characters | ||
| rmQuote := strings.NewReplacer(`"`, "", `'`, "", "`", "") |
There was a problem hiding this comment.
Why do I need the stripping?
There was a problem hiding this comment.
The unit tests are modeled after ip_slice tests, which one of the tests is to test bad quoting.
The quotes need to be removed to handle this case of funny quoting.
If this is not needed, I can remove it.
There was a problem hiding this comment.
@eparis I answered the question, please let me know if this is still a concern.
|
@eparis If you have a chance, can you take another look at this? |
|
@thaJeztah @eparis can we merge this? I believe @rpothier is no longer working on the dual-stack work in kubernetes but this feature would be very helpful to others who are. Thank you. |
|
I'm not a maintainer in this repository, and don't have write access. @spf13 any way you could help getting this moving? |
|
Yea, I've been reassigned and no longer on Kubernetes. |
|
@therealmitchconnors @eparis PTAL 🙏 |
|
Thanks! |
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/spf13/pflag](https://github.com/spf13/pflag) | require | patch | `v1.0.5` -> `v1.0.6` | --- ### Release Notes <details> <summary>spf13/pflag (github.com/spf13/pflag)</summary> ### [`v1.0.6`](https://github.com/spf13/pflag/releases/tag/v1.0.6) [Compare Source](spf13/pflag@v1.0.5...v1.0.6) #### What's Changed - Add exported functions to preserve `pkg/flag` compatibility by [@​mckern](https://github.com/mckern) in spf13/pflag#220 - remove dead code for checking error nil by [@​yashbhutwala](https://github.com/yashbhutwala) in spf13/pflag#282 - Add IPNetSlice and unit tests by [@​rpothier](https://github.com/rpothier) in spf13/pflag#170 - allow for blank ip addresses by [@​duhruh](https://github.com/duhruh) in spf13/pflag#316 - add github actions by [@​sagikazarmark](https://github.com/sagikazarmark) in spf13/pflag#419 #### New Contributors - [@​mckern](https://github.com/mckern) made their first contribution in spf13/pflag#220 - [@​yashbhutwala](https://github.com/yashbhutwala) made their first contribution in spf13/pflag#282 - [@​rpothier](https://github.com/rpothier) made their first contribution in spf13/pflag#170 - [@​duhruh](https://github.com/duhruh) made their first contribution in spf13/pflag#316 - [@​sagikazarmark](https://github.com/sagikazarmark) made their first contribution in spf13/pflag#419 **Full Changelog**: spf13/pflag@v1.0.5...v1.0.6 </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDYuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> See merge request alpine/infra/build-server-status!19
6 participants
This adds slices for IPNet.
This is needed for IPv4, IPv6 dual stack in kubernetes.