Add additional languages and toolchains#368
Add additional languages and toolchains#368radu-matei merged 1 commit intomainfrom unknown repository
Conversation
ghost
marked this pull request as draft
ghost
changed the title
|
|
||
| # Install additional rust components (rust-analyzer) | ||
| ARG RUST_ANALYZER_URL="https://github.com/rust-lang/rust-analyzer/releases/download/2022-04-11/rust-analyzer-x86_64-unknown-linux-gnu.gz" | ||
| RUN curl -sL "$RUST_ANALYZER_URL" | gunzip -c - > /usr/local/bin/rust-analyzer && chmod +x /usr/local/bin/rust-analyzer |
There was a problem hiding this comment.
I'd probably prefer to use rustup component add rust-analyzer here but it seems like rust-analyzer was added and then removed temporarily til it's stable, see rust-lang/rustup#2560
| "fermyon.autobindle", | ||
| "golang.Go", | ||
| "grain-lang.vscode-grain", | ||
| "saulecabrera.asls" |
There was a problem hiding this comment.
This appears to be the more active VS Code extension from Shopify: https://github.com/Shopify/vscode-as
There was a problem hiding this comment.
Is this preferred for AssemblyScript vs. the regular JavaScript / TypeScript extension?
There was a problem hiding this comment.
Not sure, I can reach out to folks in the AssemblyScript Discord and see what they've been using/prefer.
There was a problem hiding this comment.
Actually, it probably makes sense to just use the regular JavaScript / TypeScript extension by Microsoft (https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-next). If there's a recommendation from the AS core team, I can open up a follow-up.
EDIT: will follow-up in another PR if consensus is to use the regular extension
There was a problem hiding this comment.
That is configured by default anyway.
Let's see if using the AssemblyScript tooling is an improvement, there are quite a things not caught by the JS language server when writing AssemblyScript.
ghost
marked this pull request as ready for review
|
I think this PR is now ready for review. I have not tested the vs code integration, but I've tested and confirmed that each of the added language and toolchain is available inside the container (I did this by just running a |
|
This looks good to me. Thanks! |
|
Done! |
2 participants
This PR adds a couple of languages and toolchains that support WebAssembly. See #198.
gopls)