Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
9fcc1b3
Initial commit
MartinCardozo-SDK Aug 8, 2025
d342431
New SplitEventWithMetadata
MartinCardozo-SDK Aug 8, 2025
7378c38
Switching branch
MartinCardozo-SDK Aug 8, 2025
f68cfb0
Stable point
MartinCardozo-SDK Aug 11, 2025
23ed38f
Merge branch 'FME-8393-Events-Baseline' into FME-8393-Events-Metadata
MartinCardozo-SDK Aug 11, 2025
ba7328c
Simplified tests
MartinCardozo-SDK Aug 11, 2025
740f793
Equatable removed from SplitActionWithMetadata
MartinCardozo-SDK Aug 11, 2025
8dd3be6
EventsManager Mock and Stub now record the events correctly
MartinCardozo-SDK Aug 11, 2025
0b885a4
Tests fixed
MartinCardozo-SDK Aug 11, 2025
ad58ec3
Tests fixed
MartinCardozo-SDK Aug 11, 2025
30e203a
Tests covering the new events listeners with metadata
MartinCardozo-SDK Aug 11, 2025
ed50d1c
Removed code from the next feature (Events Errors)
MartinCardozo-SDK Aug 11, 2025
a759fa7
Added nested comment for SonarQuabe quality gate
MartinCardozo-SDK Aug 11, 2025
9270d65
Tests added to conform to SonarQube quality gate
MartinCardozo-SDK Aug 11, 2025
71c5f68
Typo fixed:
MartinCardozo-SDK Aug 11, 2025
93c1b96
SplitEventsTests added to TestPlan
MartinCardozo-SDK Aug 11, 2025
e9b139d
Test added to cover listening with metadata on a Queue
MartinCardozo-SDK Aug 11, 2025
eafca8f
Added sdkError cases
MartinCardozo-SDK Aug 12, 2025
4263d1a
Merge pull request #718 from splitio/FME-8393-Events-Metadata
MartinCardozo-SDK Aug 12, 2025
647ebe9
Tests added
MartinCardozo-SDK Aug 13, 2025
5ca81f3
Removing empty line changes for better readability
MartinCardozo-SDK Aug 13, 2025
d0201be
Added two more test to cover the case were response from server is 20…
MartinCardozo-SDK Aug 13, 2025
b4c9e44
Update Split/Events/SplitEventsManager.swift
MartinCardozo-SDK Aug 13, 2025
a2ddfc6
Better comments
MartinCardozo-SDK Aug 13, 2025
12f5af2
Merge branch 'FME-8356-Errors' of github.com:splitio/ios-client into …
MartinCardozo-SDK Aug 13, 2025
eefa195
Cleanup of Workers
MartinCardozo-SDK Aug 13, 2025
b845d46
Better comments. Errors now on camel case to follow convention.
MartinCardozo-SDK Aug 13, 2025
77c4528
Merge branch 'FME-8356-Errors' into FME-8356-Cleanup
MartinCardozo-SDK Aug 13, 2025
e6d87a5
Removed unnecessary types to let Swift infer it
MartinCardozo-SDK Aug 13, 2025
20385cb
New comments
MartinCardozo-SDK Aug 13, 2025
d3f55fa
Merge branch 'FME-8356-Errors' into FME-8356-Cleanup
MartinCardozo-SDK Aug 13, 2025
d0b2b85
Initializers shrinked for better readability
MartinCardozo-SDK Aug 13, 2025
8544340
Methods requeriments condensed
MartinCardozo-SDK Aug 13, 2025
9ca0010
Minor details
MartinCardozo-SDK Aug 13, 2025
41904f5
Merge pull request #720 from splitio/FME-8356-Errors
MartinCardozo-SDK Aug 13, 2025
625a5d7
Merge pull request #721 from splitio/FME-8356-Cleanup
MartinCardozo-SDK Aug 13, 2025
42c1dd1
Unintended Synchronization bug removed
MartinCardozo-SDK Aug 14, 2025
beb3215
Merge branch 'development' into FME-8393-Events-Baseline
MartinCardozo-SDK Aug 14, 2025
a444c3b
Retry on failure for all tests
MartinCardozo-SDK Aug 15, 2025
74b6ce5
Flaky test of wrong JSON for Segments fixed
MartinCardozo-SDK Aug 15, 2025
ed87a88
Test Fixed
MartinCardozo-SDK Aug 15, 2025
6102e9f
Flaky test fixed
MartinCardozo-SDK Aug 15, 2025
b35691e
Merge branch 'development' into FME-8393-Events-Baseline
MartinCardozo-SDK Aug 15, 2025
0715bff
StorageHelper restored
MartinCardozo-SDK Aug 15, 2025
b09b580
Merge branch 'development' into FME-8393-Events-Baseline
MartinCardozo-SDK Aug 15, 2025
48521f4
Merge branch 'development' into FME-8393-Events-Baseline
MartinCardozo-SDK Sep 17, 2025
64122ce
Conforming to new spec
MartinCardozo-SDK Sep 18, 2025
c705cae
Merge branch 'FME-8393-Event push::ts-Baseline' of github.com:splitio…
MartinCardozo-SDK Sep 18, 2025
cd69e09
Conflicts with removed BlockingQueue solved
MartinCardozo-SDK Sep 25, 2025
c462440
Tests fixed to conform to new String constants
MartinCardozo-SDK Sep 25, 2025
ec5310e
Tests corrected
MartinCardozo-SDK Sep 29, 2025
3b8a98b
Events Swift 6 compatible
MartinCardozo-SDK Jan 8, 2026
4f94e08
Test fixed
MartinCardozo-SDK Jan 8, 2026
4be76b6
Test updated
MartinCardozo-SDK Jan 8, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed code from the next feature (Events Errors)
  • Loading branch information
MartinCardozo-SDK committed Aug 11, 2025
commit ed50d1cf6fefdf6846b6184aed3b3ef1e3a83185
3 changes: 1 addition & 2 deletions Split/Events/EventsManagerCoordinator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ class MainSplitEventsManager: SplitEventsManagerCoordinator {
private let eventsToHandle: Set<SplitInternalEvent> = Set(
[.splitsLoadedFromCache,
.splitsUpdated,
.splitKilledNotification,
.sdkError]
.splitKilledNotification]
)

func notifyInternalEvent(_ event: SplitInternalEvent) {
Expand Down
3 changes: 0 additions & 3 deletions Split/Events/SplitEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import Foundation
case sdkReadyTimedOut
case sdkReadyFromCache
case sdkUpdated
case sdkError

public func toString() -> String {
switch self {
Expand All @@ -34,8 +33,6 @@ import Foundation
return "SDK_READY_TIMED_OUT"
case .sdkReadyFromCache:
return "SDK_READY_FROM_CACHE"
case .sdkError:
return "SDK_ERROR"
}
}
}
4 changes: 0 additions & 4 deletions Split/Events/SplitEventsManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,6 @@ class DefaultSplitEventsManager: SplitEventsManager {
if !isTriggered(external: .sdkReady) {
trigger(event: .sdkReadyTimedOut)
}
case .sdkError:
if !isTriggered(external: .sdkReady) {
trigger(event: SplitEventWithMetadata(type: .sdkUpdated, metadata: event.metadata))
}
}
}
}
Expand Down
1 change: 0 additions & 1 deletion Split/Events/SplitInternalEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,4 @@ enum SplitInternalEvent {
case attributesLoadedFromCache
case sdkReadyTimeoutReached
case splitKilledNotification
case sdkError
}
2 changes: 0 additions & 2 deletions SplitTests/Helpers/IntegrationHelper.swift
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,6 @@ class IntegrationHelper {
return "myLargeSegmentsUpdated"
case .myLargeSegmentsLoadedFromCache:
return "myLargeSegmentsLoadedFromCache"
case .sdkError:
return "sdkError"
}
}

Expand Down
Loading