[FME-12340] - Metadata - Managers #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Readiness Test Results ✅
Legend: 🟢 significant improvement | 🔴 significant regression | ⚪ inconclusive (p≥0.05) ios-test-mock
|
MartinCardozo-SDK
changed the title
SDK Readiness Test Results ✅
Legend: 🟢 significant improvement | 🔴 significant regression | ⚪ inconclusive (p≥0.05) ios-test-mock
|
SDK Readiness Test Results ✅
Legend: 🟢 significant improvement | 🔴 significant regression | ⚪ inconclusive (p≥0.05) ios-test-mock
|
gthea
reviewed
Jan 19, 2026
Comment on lines
+29
to
+43
|
|
||
| @objcMembers public final class SplitEventWithMetadata: NSObject, Sendable { | ||
| let type: SplitEvent | ||
| let metadata: EventMetadata? | ||
|
|
||
| @available(*, unavailable) | ||
| override init() { | ||
| fatalError("Use SDK-provided instances only") | ||
| } | ||
|
|
||
| internal init(type: SplitEvent, metadata: EventMetadata? = nil) { | ||
| self.type = type | ||
| self.metadata = metadata | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This one was replaced by the event specific metadata classes, I think.
Suggested change
| @objcMembers public final class SplitEventWithMetadata: NSObject, Sendable { | |
| let type: SplitEvent | |
| let metadata: EventMetadata? | |
| @available(*, unavailable) | |
| override init() { | |
| fatalError("Use SDK-provided instances only") | |
| } | |
| internal init(type: SplitEvent, metadata: EventMetadata? = nil) { | |
| self.type = type | |
| self.metadata = metadata | |
| } | |
| } |
Contributor
There was a problem hiding this comment.
We may have to add some explicit addEventsListener tests.
SDK Readiness Test Results ✅
Legend: 🟢 significant improvement | 🔴 significant regression | ⚪ inconclusive (p≥0.05) ios-test-mock
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS SDK
What did you accomplish?
EventsManager updated.
How do we test the changes introduced in this PR?
Extra Notes
Tests on Next PR