Skip to content

Feature/sem ver #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmelograno merged 3 commits into from
May 10, 2024
Merged

Feature/sem ver #529

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93a0270
Merge branch 'Feature/SemVer' of github.com:splitio/python-client int…
mmelograno May 10, 2024
5292c94
returning bool on segment_contains
mmelograno May 10, 2024
bd216bb
segment_contains compliance
mmelograno May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
segment_contains compliance
  • Loading branch information
@mmelograno
mmelograno committed May 10, 2024
commit bd216bba0bc4bd7b82f710133d4b2bce31688be7
2 changes: 1 addition & 1 deletion splitio/storage/pluggable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ def segment_contains(self, segment_name, key):
except Exception:
_LOGGER.error('Error checking segment key')
_LOGGER.debug('Error: ', exc_info=True)
return None
return False

def get_segment_keys_count(self):
"""
Expand Down
2 changes: 1 addition & 1 deletion splitio/storage/redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ def segment_contains(self, segment_name, key):
except RedisAdapterException:
_LOGGER.error('Error testing members in segment stored in redis')
_LOGGER.debug('Error: ', exc_info=True)
return None
return False

def get_segments_count(self):
"""
Expand Down