[FME-12498] Added impression properties in treatments #59
+154
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return dtos.NewFallbackTreatmentCalculatorImp(&fallbackTreatmentConf) | ||
| } | ||
|
|
||
| func serializeProperties(opts *dtos.EvaluationOptions) string { |
There was a problem hiding this comment.
I think it’s already covered, but just in case, we should verify that when no evaluation options or properties are provided (or when the provided properties are invalid), the properties field is omitted from the backend payload (same as the SDKs).
Also, I think the impression sent to the thin client should not include the properties field when serializeProperties returns an empty string. Otherwise (not 100% sure) it might break compatibility with thin-client versions that don’t handle that field.
EmilianoSanchez
approved these changes
Jan 20, 2026
EmilianoSanchez
left a comment
EmilianoSanchez
left a comment
There was a problem hiding this comment.
LGTM, just a comment to double-check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPLIT DAEMON
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes