Skip to content

fix: make the wasm resolve thread safe #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vahidlazio merged 1 commit into from
Aug 18, 2025
Merged

fix: make the wasm resolve thread safe #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion openfeature-provider-local/src/main/java/com/spotify/confidence/SwapWasmResolverApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.spotify.confidence.shaded.flags.resolver.v1.ResolveFlagsRequest;
import com.spotify.confidence.shaded.flags.resolver.v1.ResolveFlagsResponse;
import java.util.concurrent.atomic.AtomicReference;
import java.util.concurrent.locks.ReentrantLock;

class SwapWasmResolverApi {
private final AtomicReference<WasmResolveApi> wasmResolverApiRef = new AtomicReference<>();
Expand All @@ -29,7 +30,12 @@ public void updateState(byte[] state) {
isPrimary = !isPrimary;
}

private final ReentrantLock logResolveLock = new ReentrantLock();

public ResolveFlagsResponse resolve(ResolveFlagsRequest request) {
return wasmResolverApiRef.get().resolve(request);
logResolveLock.lock();
final var response = wasmResolverApiRef.get().resolve(request);
logResolveLock.unlock();
return response;
}
}