This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix parser for remote thread dumps#10
Merged
Merged
Conversation
added 2 commits
February 28, 2016 20:50
…mote thread dump is captured the os thread information is missing
walles
added a commit
that referenced
this pull request
Mar 1, 2016
Fix parser for remote thread dumps
Contributor
|
Just splendid, with tests and everything, thanks a lot Raymond! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7
A threads header string is different when it is taken remotely via jvisual vm. Specifically the metadata info that follows a thread name is missing. Such as
Instead the thread is only given a simple thread id in the form 't@X' where X is a hex number. Example
This PR fixes the parser to check for both header styles