Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Listed Thread-Names in top running method list#13

Merged
walles merged 1 commit into
spotify:gh-pagesfrom
GaneshSPatil:top-running-methods-thread-name
Dec 9, 2016
Merged

Listed Thread-Names in top running method list#13
walles merged 1 commit into
spotify:gh-pagesfrom
GaneshSPatil:top-running-methods-thread-name

Conversation

@GaneshSPatil
Copy link
Copy Markdown
Contributor

In the Top Running Methods list, list thread names per top method and link them all to the stack traces list.

Comment thread stylesheet.css Outdated
margin-top: 0.25em;
}

#RUNNING td {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's RUNNING used for? Can't see it referenced anywhere.

@walles
Copy link
Copy Markdown
Contributor

walles commented Jun 29, 2016

Hi @GaneshSPatil!

How have you have tested this change?

Regards /Johan

@GaneshSPatil GaneshSPatil force-pushed the top-running-methods-thread-name branch from 5d74505 to 779d96e Compare July 22, 2016 16:15
@GaneshSPatil
Copy link
Copy Markdown
Contributor Author

Hey @walles -- sorry for getting back so late,
fixed the comments that you mentioned on the PR
i have updated the PR with new changes

… link them all to the stack traces list.

fixed the test failures
Added tests for top_methods_from_running_threads
@walles walles merged commit 1e82484 into spotify:gh-pages Dec 9, 2016
@walles
Copy link
Copy Markdown
Contributor

walles commented Dec 11, 2016

Sorry for the silly long delay Ganesh, thanks for the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants