Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

support loading stack file addresses from query string#22

Closed
craynic wants to merge 1 commit into
spotify:gh-pagesfrom
craynic:master
Closed

support loading stack file addresses from query string#22
craynic wants to merge 1 commit into
spotify:gh-pagesfrom
craynic:master

Conversation

@craynic
Copy link
Copy Markdown

@craynic craynic commented Oct 23, 2019

No description provided.

@walles
Copy link
Copy Markdown
Contributor

walles commented Oct 24, 2019

Hi @craynic, thanks for this!

Could you please add:

  • An example-dump.txt file with an example thread dump

  • A clickable URL to both index.html and README.md showing how to use the by-query-string feature to analyze the example dump.

    Regards /Johan

@craynic
Copy link
Copy Markdown
Author

craynic commented Oct 25, 2019

http://craynic.github.io/tda/index.html?url=stacks/jstack.sample.txt
It could be a demo for this feature.

@craynic
Copy link
Copy Markdown
Author

craynic commented Oct 25, 2019

I don't known how to write a readme. Is there any sample or template?

@walles
Copy link
Copy Markdown
Contributor

walles commented Oct 25, 2019

There's a README.md file at the top of this repo, just add it there!

And to the index.html, since that's what people will see when they just come from Google or wherever.

@walles
Copy link
Copy Markdown
Contributor

walles commented Nov 7, 2019

I just realized I don't think this works across domains; if I merged this it would only work for URLs on the spotify.github.io domain, which would be pretty useless.

For a demo, try this link and watch your Javascript console, note the CORS warning:
http://craynic.github.io/tda/index.html?url=https://www.kth.se

Google "CORS" to learn more, but I think it's not possible to get this working cross domains :(.

@craynic
Copy link
Copy Markdown
Author

craynic commented Nov 9, 2019

Sorry I'm a little busy these days. In our usage we do serve the script and stack files on a same domain.
Very sorry for that. I will close this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants