This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Rewrite Analysis.toString()#3
Merged
Merged
Conversation
Split it into one part that lists threads with stacktraces, and one part that turns that into a string representation. This is a first step towards turning the analysis part of the web page into HTML. Fails one test though, needs debugging.
Validate full analysis test output vs an array of lines rather than a big string. This makes empty lines properly highlighted on the results web page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move logic into another method and make Analysis.toString() just render the result of that method.
This is in preparation for turning the threads list into proper HTML from