Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Added a minimal bootstrap theme#8

Closed
indigo423 wants to merge 2 commits into
spotify:gh-pagesfrom
opennms-forge:minimal-theme
Closed

Added a minimal bootstrap theme#8
indigo423 wants to merge 2 commits into
spotify:gh-pagesfrom
opennms-forge:minimal-theme

Conversation

@indigo423
Copy link
Copy Markdown

I've created a minimal bootstrap theme to have it running as a standalone service for our open source project. Thank you very much great idea and very cool tool.

@walles
Copy link
Copy Markdown
Contributor

walles commented Feb 26, 2016

Hi!

Could you please rebase your change on the latest gh-pages?

Travis wasn't building things as expected, and I'd like to ensure your changes passes the linter steps before merging anything.

Regards /Johan

@indigo423
Copy link
Copy Markdown
Author

I'll fix the npm test complaints.

Message:
    1 error found in /home/travis/build/spotify/threaddump-analyzer/index.html
[L108:C5] Tag must be paired, no start tag: [ </div> ] (tag-pair)
events.js:154
      throw er; // Unhandled 'error' event
      ^
Error: CSSLint failed for stylesheet.css
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.
Done. Your build exited with 1.

@walles
Copy link
Copy Markdown
Contributor

walles commented Feb 27, 2016

Another thing, the files in css, are they

  • generated? If so, could you add a section to README.md describing how to (re)generate them?
  • copied from somewhere else? If so, can they be linked from there rather than being part of the project?

@walles
Copy link
Copy Markdown
Contributor

walles commented Dec 9, 2016

@indigo423, I'm closing this for now since not much has happened lately.

If you still want to get this in, feel free to re-open after making sure the tests pass and clarifying where the css files come from.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants