Added Tidal search exclusion rules config (and ConfigHolder class)#27
Open
vaosilva wants to merge 1 commit intospotify2tidal:mainfrom
Open
Added Tidal search exclusion rules config (and ConfigHolder class)#27vaosilva wants to merge 1 commit intospotify2tidal:mainfrom
vaosilva wants to merge 1 commit intospotify2tidal:mainfrom
Conversation
timrae
requested changes
May 7, 2024
| return [(item['spotify_id'], item['tidal_id']) for item in config['sync_playlists']] | ||
| return [(item['spotify_id'], item['tidal_id']) for item in ConfigHolder.get_config()['sync_playlists']] | ||
|
|
||
| class ConfigHolder: |
Collaborator
There was a problem hiding this comment.
I think a class that is never instantiated like this is a bit weird and not very pythonic. Probably better to use a config module with an importable config variable like this:
Collaborator
There was a problem hiding this comment.
Probably better to sync with @joshrmcdaniel and wait for his changes to merge before doing this however:
#29 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again,
I had some problems with karaoke versions of tracks showing up in my playlists, so I thought of applying this small refactoring. Moved the exclusion rules to the yaml config file and introduced a ConfigHolder class for easier access of configs.
Like in my previous pull request, if you have any comment regarding improvements or whatnot please be free to reach back, I will try to comply promptly.