Skip to content

Add Default Client TimeOut. - #4117

Closed
wzwllu wants to merge 5 commits into
spring-cloud:mainfrom
wzwllu:main
Closed

Add Default Client TimeOut.#4117
wzwllu wants to merge 5 commits into
spring-cloud:mainfrom
wzwllu:main

Conversation

@wzwllu

@wzwllu wzwllu commented Aug 8, 2022

Copy link
Copy Markdown

Add connectRequestTimeout,connectTimeout,readTimeout。

Add connectRequestTimeout,connectTimeout,readTimeout。
@wzwllu

wzwllu commented Aug 8, 2022

Copy link
Copy Markdown
Author

Why the tests failed on CircleCI?
Only add the timeOut Config.

wzwllu added 3 commits August 9, 2022 01:03
nothing
test CL
fix for Getting all instance registry info without timeout spring-cloud#4110
@wzwllu

wzwllu commented Aug 8, 2022

Copy link
Copy Markdown
Author

If remove codes , CL is error too;
It's 7d696c9....
please check the CL test.

@OlgaMaciaszek

Copy link
Copy Markdown
Collaborator

Hello, @wzwllu Thanks for submitting the PR. The tests will fail on main currently due to necessary changes waiting for merge in Netflix/Eureka. Please submit your PR against the 3.1.x branch instead of main.

@OlgaMaciaszek OlgaMaciaszek self-assigned this Aug 31, 2022

@OlgaMaciaszek OlgaMaciaszek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify so that the values are configurable via .properties files, for example by adding a static class dedicated to Apache Client properties in EurekaClientConfigBean. Also, make sure the default values are set up there.

@OlgaMaciaszek OlgaMaciaszek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify so that the values are configurable via .properties files, for example by adding a static class dedicated to Apache Client properties in EurekaClientConfigBean. Also, make sure the default values are set up there.
Please add tests and documentation.
Also, as indicated in the previous comment, please submit these changes against the 3.1.x branch instead of main.

@OlgaMaciaszek

Copy link
Copy Markdown
Collaborator

Fixes gh-4110.

@OlgaMaciaszek OlgaMaciaszek linked an issue Sep 1, 2022 that may be closed by this pull request
@kworkbee

kworkbee commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

I wrote a new PR that satisfies the conditions. Ref

@OlgaMaciaszek

Copy link
Copy Markdown
Collaborator

Closing in favour of #4148.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting all instance registry info without timeout

4 participants