Add Default Client TimeOut. - #4117
Conversation
Add connectRequestTimeout,connectTimeout,readTimeout。
|
Why the tests failed on CircleCI? |
fix for Getting all instance registry info without timeout spring-cloud#4110
|
If remove codes , CL is error too; |
|
Hello, @wzwllu Thanks for submitting the PR. The tests will fail on |
Default time out 20s
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Please modify so that the values are configurable via .properties files, for example by adding a static class dedicated to Apache Client properties in EurekaClientConfigBean. Also, make sure the default values are set up there.
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Please modify so that the values are configurable via .properties files, for example by adding a static class dedicated to Apache Client properties in EurekaClientConfigBean. Also, make sure the default values are set up there.
Please add tests and documentation.
Also, as indicated in the previous comment, please submit these changes against the 3.1.x branch instead of main.
|
Fixes gh-4110. |
|
I wrote a new PR that satisfies the conditions. Ref |
|
Closing in favour of #4148. |
Add connectRequestTimeout,connectTimeout,readTimeout。