Add nested override coverage for SpringBootTest imports#50625
Open
SJvaca30 wants to merge 1 commit into
Open
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
SJvaca30
force-pushed
the
test-nested-configuration-spring-boot
branch
from
ff3cc47 to
7068877
Compare
Signed-off-by: SJLIM <yyvaca30@gmail.com>
SJvaca30
force-pushed
the
test-nested-configuration-spring-boot
branch
from
7068877 to
629f9ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
@NestedTestConfiguration(OVERRIDE)coverage toSpringBootTestImportTests.The existing nested tests verify the default inherited behavior where the enclosing class's
@Importand@TestPropertySourceare honored by a nested@SpringBootTest. The new nested test class verifies the contrasting override behavior: the nested class keeps its own@Import, but no longer inherits the enclosing class's import or test property source.See gh-23929.
Validation:
./gradlew :core:spring-boot-test:test --tests org.springframework.boot.test.context.SpringBootTestImportTests --rerun-tasks --no-daemon./gradlew :core:spring-boot-test:checkFormatTest :core:spring-boot-test:checkstyleTest --no-daemongit diff --checkAdditional check:
@NestedTestConfiguration(EnclosingConfiguration.OVERRIDE)made the new override assertions fail, confirming the test covers the intended behavior.